Add dump_content function to avoid unclear item_content transformation process#90
Add dump_content function to avoid unclear item_content transformation process#90MHHukiewitz wants to merge 8 commits intomainfrom
dump_content function to avoid unclear item_content transformation process#90Conversation
|
Can you explain the issue in more details ? I do not understand what the problem is from this short description. |
|
Well, I figured that some functions in connection with messages are too important, to have them spread out around the different repos. IMHO we want:
This way we can also write tests for the validators, to make sure that what transformations we implemented here, are working fine with the current message spec. |
|
This branch is mixing unrelated stuff, can you move |
…fault method to dump message content
f7cc2fb to
3febd8e
Compare
|
Is the code coverage increasing or at least identical after these changes ? I don't see changes in the tests. |
93% -> 92%, due to the decreasing coverage on the |
56b4568 to
9bd0cc6
Compare
|
Closing stale PRs. If you think this is still relevant ping me! |
In order to avoid mistakes when creating the
item_contentof a message, theextended_json_encoderhas been added from thealeph-sdk-pythonpackage to this central piece of the aleph architecture.Based on #89